Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeviceMemoryUsage: add AMD support, use ProcessLogger for version.sh #1060

Merged
merged 8 commits into from
Aug 28, 2024

Conversation

matthiasdiener
Copy link
Member

Questions for the review:

  • Is the scope and purpose of the PR clear?
    • The PR should have a description.
    • The PR should have a guide if needed (e.g., an ordering).
  • Is every top-level method and class documented? Are things that should be documented actually so?
  • Is the interface understandable? (I.e. can someone figure out what stuff does?) Is it well-defined?
  • Does the implementation do what the docstring claims?
  • Is everything that is implemented covered by tests?
  • Do you see any immediate risks or performance disadvantages with the design? Example: what do interface normals attach to?

@matthiasdiener matthiasdiener self-assigned this Aug 26, 2024
@matthiasdiener matthiasdiener changed the title DeviceMemoryUsage: only use on Nvidia, use ProcessLogger for version.sh DeviceMemoryUsage: add AMD support, use ProcessLogger for version.sh Aug 27, 2024
Copy link
Collaborator

@majosm majosm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of minor suggestions, otherwise LGTM.

mirgecom/array_context.py Outdated Show resolved Hide resolved
mirgecom/array_context.py Outdated Show resolved Hide resolved
@matthiasdiener matthiasdiener enabled auto-merge (squash) August 28, 2024 02:18
@matthiasdiener matthiasdiener merged commit 263582b into main Aug 28, 2024
13 checks passed
@matthiasdiener matthiasdiener deleted the DeviceMemoryUsage-cuda branch August 28, 2024 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants